Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#114 - fixed FileField json serialization error in train response #124

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

Stifo
Copy link
Contributor

@Stifo Stifo commented Oct 26, 2023

Description

Replacing FileField in the return of build_train_response with a new JSON-serializable class UploadedFileInfo to fix the error. This is a similar approach to that of in pr

Fixes #114

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested with the demo_app, while a FileField arg has been added to the train schema.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Stifo Stifo marked this pull request as ready for review October 30, 2023 09:21
@Stifo Stifo merged commit 6e015bb into master Nov 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

POST /v2/models/{model} raises FileField is not JSON serializable with file argumetns
2 participants